-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(SPV-793): add function to parse query params into new search struct #675
Conversation
…whole query params and returns errors
… search params struct.
Manual Tests💚 Manual testing by @chris-4chain resulted in success. |
489c73e
to
10f94a4
Compare
…ding typed parameter.
…ery-params # Conflicts: # internal/query/gin_map.go # internal/query/gin_map_test.go # internal/query/map.go
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #675 +/- ##
==========================================
- Coverage 49.16% 49.12% -0.05%
==========================================
Files 261 263 +2
Lines 12163 12200 +37
==========================================
+ Hits 5980 5993 +13
- Misses 5592 5613 +21
- Partials 591 594 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
4d7dca4
to
1acd5c8
Compare
Pull Request Checklist