Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(SPV-793): add function to parse query params into new search struct #675

Merged
merged 6 commits into from
Aug 26, 2024
Merged

feat(SPV-793): add function to parse query params into new search struct #675

merged 6 commits into from
Aug 26, 2024

Conversation

dorzepowski
Copy link
Contributor

@dorzepowski dorzepowski commented Aug 23, 2024 •
edited
Loading

Pull Request Checklist

  • 📖 I created my PR using provided : CODE_STANDARDS
  • 📖 I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • ✅ I have provided tests for my changes.
  • 📝 I have used conventional commits.
  • 📗 I have updated any related documentation.
  • 💾 PR was issued based on the Github or Jira issue.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 23, 2024 •
edited
Loading

Manual Tests

💚 Manual testing by @chris-4chain resulted in success.

@dorzepowski dorzepowski force-pushed the feat/func-to-parse-query-params branch from 489c73e to 10f94a4 Compare August 26, 2024 10:50
Base automatically changed from feat/handle-map-from-whole-query-stirng to main August 26, 2024 12:31
@dorzepowski
Merge remote-tracking branch 'origin/main' into feat/func-to-parse-qu…
e4f89c4 
…ery-params

# Conflicts:
#	internal/query/gin_map.go
#	internal/query/gin_map_test.go
#	internal/query/map.go
@dorzepowski dorzepowski marked this pull request as ready for review August 26, 2024 12:48
@dorzepowski dorzepowski requested a review from a team as a code owner August 26, 2024 12:48
@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 29.72973% with 26 lines in your changes missing coverage. Please review.

Project coverage is 49.12%. Comparing base (524c725) to head (1acd5c8).

Files Patch % Lines
mappings/search.go 0.00% 20 Missing ⚠️
internal/query/parse.go 64.70% 3 Missing and 3 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #675      +/-   ##
==========================================
- Coverage   49.16%   49.12%   -0.05%     
==========================================
  Files         261      263       +2     
  Lines       12163    12200      +37     
==========================================
+ Hits         5980     5993      +13     
- Misses       5592     5613      +21     
- Partials      591      594       +3
Flag Coverage Δ
unittests 49.12% <29.72%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
mappings/filter_old.go 0.00% <ø> (ø)
models/filter/access_key_filter.go 66.66% <ø> (ø)
models/filter/contact_filter.go 0.00% <ø> (ø)
models/filter/destination_filter.go 75.00% <ø> (ø)
models/filter/paymail_filter.go 80.00% <ø> (ø)
models/filter/transaction_filter.go 85.71% <ø> (ø)
models/filter/utxo_filter.go 73.91% <ø> (ø)
models/filter/xpub_filter.go 71.42% <ø> (ø)
internal/query/parse.go 64.70% <64.70%> (ø)
mappings/search.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 524c725...1acd5c8. Read the comment docs.

@dorzepowski dorzepowski force-pushed the feat/func-to-parse-query-params branch from 4d7dca4 to 1acd5c8 Compare August 26, 2024 13:10
@chris-4chain chris-4chain added the tested PR was tested by a team member label Aug 26, 2024
@dorzepowski dorzepowski merged commit 42f706f into main Aug 26, 2024
8 checks passed
@dorzepowski dorzepowski deleted the feat/func-to-parse-query-params branch August 26, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-4chain chris-4chain chris-4chain approved these changes

Assignees
No one assigned
Labels
tested PR was tested by a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dorzepowski @codecov-commenter @chris-4chain